Skip to content

fix: create legacy evaluate expression & add legacy-warning UI#4631

Merged
piggggggggy merged 3 commits intocloudforet-io:feature-dashboard-v2from
piggggggggy:legacy-eval
Sep 2, 2024
Merged

fix: create legacy evaluate expression & add legacy-warning UI#4631
piggggggggy merged 3 commits intocloudforet-io:feature-dashboard-v2from
piggggggggy:legacy-eval

Conversation

@piggggggggy
Copy link
Copy Markdown
Member

To Reviewers

  • Skip (style, chore, ci, minor refactoring, etc.)
  • Need discussion
  • Not that difficult
  • Approved feature branch merge to master

Description

SSIA

Things to Talk About

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 2, 2024

@piggggggggy is attempting to deploy a commit to the cloudforet Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: samuel.park <samuel.park@megazone.com>
@piggggggggy piggggggggy merged commit f3135b5 into cloudforet-io:feature-dashboard-v2 Sep 2, 2024
Copy link
Copy Markdown
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@piggggggggy piggggggggy deleted the legacy-eval branch September 2, 2024 23:58
piggggggggy added a commit that referenced this pull request Sep 2, 2024
#4632)

* fix: create legacy evaluate expression & add legacy-warning UI



* chore: translation



* chore: solve small bug



---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
Co-authored-by: yuda <yuda@megazone.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants